Skip to content

LRT: Add test namespaces to cleanup script - #9437

Closed
kachawla wants to merge 3 commits into
radius-project:mainfrom
kachawla:cleanup-namespaces
Closed

LRT: Add test namespaces to cleanup script#9437
kachawla wants to merge 3 commits into
radius-project:mainfrom
kachawla:cleanup-namespaces

Conversation

@kachawla

@kachawla kachawla commented May 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Long running tests have been recently failing with the error (copied below) that the test namespace already exists. This PR adds the missing test namespaces to the cleanup script to ensure that the namespaces created for tests are deleted at the end of each run.

Ideally each test should be responsible for cleaning up resources created by the test (will log an issue for this) or do #7966 at least. For now I'm following our current approach to clean up adding the missing namespaces to the cleanup script.

  deploymenttemplate_test.go:218: 
        	Error Trace:	/home/runner/work/radius/radius/test/functional-portable/kubernetes/noncloud/deploymenttemplate_test.go:218
        	Error:      	Received unexpected error:
        	            	deploymenttemplates.radapp.io "dt-recipe" already exists
        	Test:       	Test_DeploymentTemplate_Recipe/Create_DeploymentTemplate

Type of change

  • This pull request fixes a bug in Radius and has an approved issue (issue link required).

Fixes: #9371 and #9355

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@kachawla
LRT: Add test namespaces to cleanup script
9c90a03 
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
@kachawla
kachawla requested review from a team as code owners May 12, 2025 22:15
@kachawla
kachawla temporarily deployed to functional-tests May 12, 2025 22:15 — with GitHub Actions Inactive
@kachawla
kachawla temporarily deployed to publish-bicep May 12, 2025 22:15 — with GitHub Actions Inactive
@kachawla
kachawla temporarily deployed to functional-tests May 13, 2025 04:17 — with GitHub Actions Inactive
@kachawla
kachawla temporarily deployed to publish-bicep May 13, 2025 04:17 — with GitHub Actions Inactive
@radius-functional-tests

radius-functional-tests Bot commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 9c90a03
Unique ID func37ab87ccf2
Image tag pr-func37ab87ccf2
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func37ab87ccf2
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func37ab87ccf2
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func37ab87ccf2
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func37ab87ccf2
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func37ab87ccf2
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@radius-functional-tests

radius-functional-tests Bot commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref d593d40
Unique ID funca87ea104b6
Image tag pr-funca87ea104b6
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funca87ea104b6
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funca87ea104b6
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funca87ea104b6
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funca87ea104b6
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funca87ea104b6
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@codecov

codecov Bot commented May 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@9e5c2fd). Learn more about missing BASE report.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9437   +/-   ##
=======================================
  Coverage        ?   55.96%           
=======================================
  Files           ?      604           
  Lines           ?    41466           
  Branches        ?        0           
=======================================
  Hits            ?    23206           
  Misses          ?    16490           
  Partials        ?     1770

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kachawla
kachawla had a problem deploying to functional-tests May 13, 2025 18:34 — with GitHub Actions Failure
@kachawla
kachawla temporarily deployed to publish-bicep May 13, 2025 18:34 — with GitHub Actions Inactive
sylvainsf
sylvainsf approved these changes May 15, 2025
View reviewed changes

@sylvainsf sylvainsf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@kachawla

kachawla commented May 16, 2025

Copy link
Copy Markdown
Member Author

Closing since #8680 inverted the list to delete everything except system namespaces as proposed in #7966.

I'll log a separate issue for each test to clean up resources created by the test as we shouldn't rely on a hardcoded list in the cleanup workflow.

@kachawla kachawla closed this May 16, 2025

This branch had an error being deployed

1 failed and 1 inactive deployments
functional-tests — a756b21b Deployed May 13, 2025 by kachawla
publish-bicep — a756b21b Deployed May 13, 2025 by kachawla
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brooke-hamilton brooke-hamilton brooke-hamilton approved these changes
+1 more reviewer
@sylvainsf sylvainsf sylvainsf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Scheduled long running test failed - Run ID: 14854634928

3 participants

@kachawla @sylvainsf @brooke-hamilton